Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable flag to every file in bin/ after install #7177

Merged
merged 1 commit into from Aug 14, 2014

Conversation

Projects
None yet
4 participants
@spinscale
Copy link
Member

spinscale commented Aug 6, 2014

The PluginManager does not preserve permissions on install due to using platform independent ZipEntry class. This patch sets the executable flag on every file in bin/ on plugin install as one is supposed to install executables in there.

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Aug 6, 2014

I guess this should work on windows as well, right?
LGTM.

@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented Aug 6, 2014

@dadoonet can you run the branch and its tests on windows?

@spinscale spinscale added the review label Aug 6, 2014

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Aug 6, 2014

@spinscale Will try tonight probably.

@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented Aug 11, 2014

tested on one windows system, where the PluginManagertests passed

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Aug 14, 2014

LGTM

@javanna javanna removed the review label Aug 14, 2014

Plugins: Add executable flag to every file in bin/ after install
The PluginManager does not preserve permissions on install. This patch
sets the executable flag on every file in bin/ on plugin install.

Closes #7177

@spinscale spinscale merged commit 6023a3a into elastic:master Aug 14, 2014

spinscale added a commit that referenced this pull request Aug 14, 2014

Plugins: Add executable flag to every file in bin/ after install
The PluginManager does not preserve permissions on install. This patch
sets the executable flag on every file in bin/ on plugin install.

Closes #7177

spinscale added a commit that referenced this pull request Sep 8, 2014

Plugins: Add executable flag to every file in bin/ after install
The PluginManager does not preserve permissions on install. This patch
sets the executable flag on every file in bin/ on plugin install.

Closes #7177

@clintongormley clintongormley changed the title Plugins: Add executable flag to every file in bin/ after install Add executable flag to every file in bin/ after install Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.