Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove operationThreaded setter from ExplainRequestBuilder #7186

Closed

Conversation

Projects
None yet
4 participants
@javanna
Copy link
Member

commented Aug 7, 2014

It's already available in base class SingleShardOperationRequestBuilder and it doesn't follow the setter convention that we adopted for request builders.
Fixed also javadocs warning caused byt missing descriptions for tag.

Java api: remove operationThreaded setter from ExplainRequestBuilder,…
… already available in base class SingleShardOperationRequestBuilder

It also didn't follow the setter convention that we adopted for request builders.
Fixed also javadocs warning caused byt missing descriptions for tag.

@javanna javanna added v1.4.0 labels Aug 7, 2014

@javanna javanna self-assigned this Aug 7, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

commented Aug 7, 2014

LGTM

javanna added a commit that referenced this pull request Aug 7, 2014

Java api: remove operationThreaded setter from ExplainRequestBuilder,…
… already available in base class SingleShardOperationRequestBuilder

It also didn't follow the setter convention that we adopted for request builders.
Fixed also javadocs warning caused byt missing descriptions for tag.

Closes #7186

@javanna javanna closed this in dbb513f Aug 7, 2014

@javanna

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2014

Side note: this change is marked as breaking as it removes a method from the Java API. Fixing compilation errors caused by this is very easy though, just replace .operationThreaded(flag) with .setOperationThreaded(flag).

@jpountz jpountz removed the review label Aug 11, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Java api: remove operationThreaded setter from ExplainRequestBuilder,…
… already available in base class SingleShardOperationRequestBuilder

It also didn't follow the setter convention that we adopted for request builders.
Fixed also javadocs warning caused byt missing descriptions for tag.

Closes #7186

@clintongormley clintongormley changed the title Java api: remove operationThreaded setter from ExplainRequestBuilder Java API: Remove operationThreaded setter from ExplainRequestBuilder Sep 8, 2014

@clintongormley clintongormley changed the title Java API: Remove operationThreaded setter from ExplainRequestBuilder Remove operationThreaded setter from ExplainRequestBuilder Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.