Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for invalid multipolygon #7190

Merged
merged 1 commit into from Aug 12, 2014

Conversation

Projects
None yet
3 participants
@colings86
Copy link
Member

colings86 commented Aug 7, 2014

Closes #7126

@colings86 colings86 added the review label Aug 7, 2014

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Aug 7, 2014

I actually like the message in the assertion better :) How about:

Invalid polygon: Two edges cross the date line at the same position
@colings86

This comment has been minimized.

Copy link
Member Author

colings86 commented Aug 7, 2014

@clintongormley the problem is that the message in the assertion is not the only reason for the exception being thrown (i.e. it was always the wrong message). For example, in this case there are not two edges crossing the date line at the same position, the problem is that the polygon representing the hole is not inside the main polygon.

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Aug 7, 2014

ahhh right, ok, how about "Invaild shape: Hole is not within polygon"

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 11, 2014

LGTM

@jpountz jpountz removed the review label Aug 11, 2014

@colings86 colings86 merged commit 128b83e into elastic:master Aug 12, 2014

@colings86 colings86 deleted the colings86:fix/7126 branch Aug 13, 2014

@colings86 colings86 self-assigned this Aug 21, 2014

@clintongormley clintongormley changed the title Geo: Better error for invalid multipolygon Better error for invalid multipolygon Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.