Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BytesStreamInput(BytesReference) ctor with nonzero offset #7197

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@rmuir
Copy link
Contributor

commented Aug 8, 2014

I renamed 'count' to 'end', since thats what it actually means for this class.

ctor 1 was broken, only worked if offset is zero.
ctor 2 had unnecessary leniency.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2014

LGTM

@rmuir rmuir added v1.4.0 labels Aug 8, 2014

@rmuir rmuir closed this Aug 8, 2014

@clintongormley clintongormley changed the title Fix BytesStreamInput(BytesReference) ctor with nonzero offset Internal: Fix BytesStreamInput(BytesReference) ctor with nonzero offset Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Fix BytesStreamInput(BytesReference) ctor with nonzero offset Fix BytesStreamInput(BytesReference) ctor with nonzero offset Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.