Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Improved CLI testing infrastructure #7198

Merged
merged 1 commit into from Aug 11, 2014

Conversation

Projects
None yet
3 participants
@spinscale
Copy link
Member

commented Aug 8, 2014

Added a LoggingTerminal class to the infrastructure, which can be used
in tests, to make sure that CLI commands write out the right data

@uboness

View changes

src/test/java/org/elasticsearch/common/cli/CliToolTestCase.java Outdated
@@ -89,4 +92,30 @@ public void close() throws IOException {
}
}

public static class LogggingTerminal extends TerminalMock {

This comment has been minimized.

Copy link
@uboness

uboness Aug 9, 2014

Contributor

s/LogggingTerminal/LogggggggggingTerminal

Logging is a bit confusing (I'd expect it to use a logger)... how about CapturingTerminal?

@uboness

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2014

small comment, other than that... LGTM

Test: Improved CLI testing infrastructure
Added a CaptureOutputTerminal class to the infrastructure, which can be used
in tests, to make sure that CLI commands write out the right data

@spinscale spinscale merged commit fbd3379 into elastic:master Aug 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.