New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that multi fields are serialized in a consistent order. #7220

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@martijnvg
Member

martijnvg commented Aug 11, 2014

This ensure that the source is the same and avoids unnecessary mapping re-syncs.

PR for #7215

Mappings: Make sure that multi fields are serialized in alphabetic or…
…der to ensure that the source is always the same.

Closes #7215
@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Aug 11, 2014

Member

LGTM, I think we should back port to 1.2 branch as well just in case we do a release there.

Member

kimchy commented Aug 11, 2014

LGTM, I think we should back port to 1.2 branch as well just in case we do a release there.

@martijnvg martijnvg added the v1.2.4 label Aug 11, 2014

@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Aug 11, 2014

Member

Pushed via: a40cb16

Member

martijnvg commented Aug 11, 2014

Pushed via: a40cb16

@martijnvg martijnvg closed this Aug 11, 2014

@jpountz jpountz removed the review label Aug 12, 2014

@martijnvg martijnvg added the bug label Aug 12, 2014

@clintongormley clintongormley changed the title from Mappings: Make sure that multi fields are serialized in a consistent order. to Mapping: Make sure that multi fields are serialized in a consistent order. Sep 8, 2014

@martijnvg martijnvg deleted the martijnvg:bugs/multi-field-order-in-source branch May 18, 2015

@clintongormley clintongormley changed the title from Mapping: Make sure that multi fields are serialized in a consistent order. to Make sure that multi fields are serialized in a consistent order. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment