Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted visibility for BroadcastShardOperationRequest subclasses and their constructors #7235

Closed

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

javanna commented Aug 12, 2014

Adjusted visibility to package private for BroadcastShardOperationRequest subclasses and their constructors

Also replaced the String,int pair for index and shard_id with ShardId object that holds the same info and serializes it the same way too.

@javanna javanna self-assigned this Aug 12, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 13, 2014

LGTM

@jpountz jpountz removed the review label Aug 13, 2014

Internal: adjusted visibility to package private for BroadcastShardOp…
…erationRequest subclasses and their constructors

Also replaced the String,int pair for index and shard_id with ShardId object that holds the same info and serialized it the same way too.

Closes #7235

@javanna javanna closed this in 270b109 Aug 13, 2014

javanna added a commit that referenced this pull request Aug 13, 2014

Internal: adjusted visibility to package private for BroadcastShardOp…
…erationRequest subclasses and their constructors

Also replaced the String,int pair for index and shard_id with ShardId object that holds the same info and serialized it the same way too.

Closes #7235

javanna added a commit that referenced this pull request Sep 8, 2014

Internal: adjusted visibility to package private for BroadcastShardOp…
…erationRequest subclasses and their constructors

Also replaced the String,int pair for index and shard_id with ShardId object that holds the same info and serialized it the same way too.

Closes #7235

@clintongormley clintongormley changed the title Internal: adjusted visibility for BroadcastShardOperationRequest subclasses and their constructors Internal: Adjusted visibility for BroadcastShardOperationRequest subclasses and their constructors Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Adjusted visibility for BroadcastShardOperationRequest subclasses and their constructors Adjusted visibility for BroadcastShardOperationRequest subclasses and their constructors Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.