Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A content decompressor that throws a human readable message when #7241

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@derryx
Copy link
Contributor

commented Aug 12, 2014

compression is disabled and the user sends compressed content.

This replaces #1678

A content decompressor that throws a human readable message when
compression is disabled and the user sends compressed content.
@dakrone

This comment has been minimized.

Copy link
Member

commented Aug 13, 2014

LGTM

@dakrone dakrone removed the review label Aug 13, 2014

@dakrone

This comment has been minimized.

Copy link
Member

commented Aug 13, 2014

Merged this to 1.x and master.

@dakrone dakrone closed this Aug 13, 2014

@kimchy

This comment has been minimized.

Copy link
Member

commented Aug 15, 2014

A bit late, but if we add the compression handler anyhow now, we might as well enable compression by default and thats it? the potential overhead now exists regardless with the additional handler, right?

@derryx

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2014

Yeah. That's right. BUT: with the changes applied you ALWAYS get a correct HTTP-answer from ES. Before when you disabled compression and sent compressed content you got a cryptic error message. That is why I changed the behavior.

@clintongormley clintongormley changed the title A content decompressor that throws a human readable message when REST API: A content decompressor that throws a human readable message when Sep 8, 2014

@clintongormley clintongormley changed the title REST API: A content decompressor that throws a human readable message when A content decompressor that throws a human readable message when Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.