Simplify OutboundHandler #72442
Merged
Simplify OutboundHandler #72442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole serializer class adds nothing but complexity. Simplified it away to make this code easier to read while saving some objects as well and making the slow warning serialize slightly nicer.
original-brownbear
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Apr 29, 2021
DaveCTurner
reviewed
Apr 29, 2021
server/src/main/java/org/elasticsearch/transport/OutboundHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/OutboundHandler.java
Outdated
Show resolved
Hide resolved
DaveCTurner
approved these changes
Apr 29, 2021
| private void internalSend(TcpChannel channel, BytesReference reference, @Nullable OutboundMessage message, | ||
| ActionListener<Void> listener) { | ||
| final long startTime = threadPool.relativeTimeInMillis(); | ||
| channel.getChannelStats().markAccessed(startTime); |
There was a problem hiding this comment.
I think we just fixed a small bug here in that we used to mark the channel as accessed before doing the serialisation, so if the serialisation failed then we'd delay the next ping without having sent anything else over the wire. No longer a problem ✅
| final long startTime = threadPool.relativeTimeInMillis(); | ||
| channel.getChannelStats().markAccessed(startTime); | ||
| final long messageSize = reference.length(); | ||
| TransportLogger.logOutboundMessage(channel, reference); |
There was a problem hiding this comment.
I think this also fixes a small bug in that the tracer will log outbound pings now. Could argue it either way, but given that we logged inbound pings already I think this makes sense ✅
|
Thanks David :) |
chengyang14
pushed a commit
to chengyang14/elasticsearch
that referenced
this pull request
May 7, 2021
The whole serializer class adds nothing but complexity. Simplified it away to make this code easier to read while saving some objects as well and making the slow warning serialize slightly nicer.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 29, 2021
The whole serializer class adds nothing but complexity. Simplified it away to make this code easier to read while saving some objects as well and making the slow warning serialize slightly nicer.
original-brownbear
added a commit
that referenced
this pull request
Jun 29, 2021
DaveCTurner
reviewed
Jan 14, 2022
| BytesReference reference = sendContext.get(); | ||
| private void internalSend(TcpChannel channel, BytesReference reference, @Nullable OutboundMessage message, | ||
| ActionListener<Void> listener) { | ||
| final long startTime = threadPool.relativeTimeInMillis(); |
There was a problem hiding this comment.
This also apparently fixes a small bug, see https://discuss.elastic.co/t/org-elasticsearch-action-get-multigetshardresponse-extremly-high-took-value/294434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole serializer class adds nothing but complexity. Simplified it away
to make this code easier to read while saving some objects as well and making
the slow warning serialize slightly cleaner to read.