Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Score: Remove explanation of query score from functions #7245

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@brwe
Copy link
Contributor

commented Aug 12, 2014

No description provided.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2014

The change looks good, maybe we should remove the query explanation from the parameters of explainScore? (only the score seems to be needed?)

@jpountz jpountz removed the review label Aug 13, 2014

remove explanation from parameter list of ScoreFunction#explainScore(…
…) and leave only the score

This also removes ExplainableSearchScript which is not used anywhere and
was the only reason to have the Explanation in the parameter anyway.
@brwe

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2014

Ok, I removed the query explanation from the parameters of explainScore. However, it was used by ExplainableSearchScript. But this class seems to be used nowhere, so I removed it.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2014

LGTM

@jpountz jpountz removed the review label Aug 18, 2014

brwe added a commit that referenced this pull request Aug 18, 2014

function_score: remove explanation of query score from functions
The score is explained already, it should not be again explained per function.

Also, remove explanation from parameter list of ScoreFunction#explainScore()
and leave only the score.

This also removes ExplainableSearchScript which is not used anywhere and
was the only reason to have the Explanation in the parameter anyway.

closes #7245

@brwe brwe closed this in 9addac8 Aug 18, 2014

@brwe brwe added the bug label Aug 19, 2014

brwe added a commit that referenced this pull request Sep 8, 2014

function_score: remove explanation of query score from functions
The score is explained already, it should not be again explained per function.

Also, remove explanation from parameter list of ScoreFunction#explainScore()
and leave only the score.

This also removes ExplainableSearchScript which is not used anywhere and
was the only reason to have the Explanation in the parameter anyway.

closes #7245

@clintongormley clintongormley changed the title function_score: remove explanation of query score fromfunctions Function Score: Remove explanation of query score from functions Sep 8, 2014

brwe added a commit to brwe/elasticsearch that referenced this pull request Nov 26, 2014

scripts: add explainable script again
explainable scripts were removed in elastic#7245 but they were used.
This commit adds them again.

closes elastic#8561

@brwe brwe referenced this pull request Nov 26, 2014

Closed

Add explainable script again #8665

brwe added a commit that referenced this pull request Jan 19, 2015

scripts: add explainable script again
explainable scripts were removed in #7245 but they were used.
This commit adds them again.

closes #8561

brwe added a commit that referenced this pull request Jan 19, 2015

scripts: add explainable script again
explainable scripts were removed in #7245 but they were used.
This commit adds them again.

closes #8561

brwe added a commit that referenced this pull request Jan 19, 2015

scripts: add explainable script again
explainable scripts were removed in #7245 but they were used.
This commit adds them again.

closes #8561

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

scripts: add explainable script again
explainable scripts were removed in elastic#7245 but they were used.
This commit adds them again.

closes elastic#8561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.