Adjusted BroadcastShardOperationResponse subclasses visibility #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way. Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter.
|
LGTM |
javanna
added a commit
that referenced
this pull request
Aug 13, 2014
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way. Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter. Closes #7255
javanna
added a commit
that referenced
this pull request
Sep 8, 2014
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way. Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter. Closes #7255
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted
BroadcastShardOperationResponsesubclasses visibility to package private when possible.Also replaced
int,Stringpair withShardIdthat holds the same info and serializes it the same way.Replaced shardId and index getters in
BroadcastOperationRequestwith a singleShardIdgetter that allows us to reuse the same object in responses.