Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted BroadcastShardOperationResponse subclasses visibility #7255

Closed

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

javanna commented Aug 13, 2014

Adjusted BroadcastShardOperationResponse subclasses visibility to package private when possible.
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way.
Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter that allows us to reuse the same object in responses.

Internal: adjusted BroadcastShardOperationResponse subclasses visibility
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way.
Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter.

@javanna javanna added v2.0.0 labels Aug 13, 2014

@javanna javanna self-assigned this Aug 13, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 13, 2014

LGTM

@jpountz jpountz removed the review label Aug 13, 2014

javanna added a commit that referenced this pull request Aug 13, 2014

Internal: adjusted BroadcastShardOperationResponse subclasses visibility
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way.
Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter.

Closes #7255

@javanna javanna closed this in 4d05d1d Aug 13, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Internal: adjusted BroadcastShardOperationResponse subclasses visibility
Also replaced int,String pair with ShardId that holds the same info and serializes it the same way.
Replaced shardId and index getters in BroadcastOperationRequest with a single ShardId getter.

Closes #7255

@clintongormley clintongormley changed the title Internal: adjusted BroadcastShardOperationResponse subclasses visibility Internal: Adjusted BroadcastShardOperationResponse subclasses visibility Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Adjusted BroadcastShardOperationResponse subclasses visibility Adjusted BroadcastShardOperationResponse subclasses visibility Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.