Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Added support for empty field arrays in mappings #7271
Fix for #6133, added the ability to send empty arrays as part of an index mapping json. For single and multi field properties objects
Sorry for the import changes, IntelliJ doesn't like eclipse imports and fights it like the devil.
If the test are in a non standard format please advise. I just find them easier to read like this.
referenced this pull request
Aug 14, 2014
@cfontes I left two comments on the PR but otherwise it looks good, especially the tests.
I would be nice to fix these imports. I'm quite surprised that you mention that you use Intellij since I thought we were using Intellij's defaults (we even have an eclipse configuration to make sure we are using Intellij's import style). Or maybe you have a non-default configuration of imports in Intellij?
Could you please also sign our contributor license agreement so that we can eventually merge this pull request?
Thanks for the review.
I will look into fixing those and push it asap.
About the imports, you are right... it's my bad, one of my other projects have a very specific rule for imports and it got into my ES project by mistake. Will fix that too.
Added back the IntelliJ default import settings.
Since there is nothing really to do in