Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the list of buckets for terms and histogram returned as a java.util.List. #7275

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

jpountz commented Aug 14, 2014

The terms and histogram aggregations always have an order. So it would make the
response easier to consume to return the buckets as a list instead of a
collection in order to make it easier to do things like getting the first/last
buckets.

Aggregations: Make the list of buckets for terms and histogram return…
…ed as a java.util.List.

The terms and histogram aggregations always have an order. So it would make the
response easier to consume to return the buckets as a list instead of a
collection in order to make it easier to do things like getting the first/last
buckets.

@jpountz jpountz added review labels Aug 14, 2014

@spinscale

This comment has been minimized.

Copy link
Member

spinscale commented Aug 18, 2014

LGTM

@jpountz jpountz removed the review label Aug 18, 2014

jpountz added a commit that referenced this pull request Aug 18, 2014

Aggregations: Make the list of buckets for terms and histogram return…
…ed as a java.util.List.

The terms and histogram aggregations always have an order. So it would make the
response easier to consume to return the buckets as a list instead of a
collection in order to make it easier to do things like getting the first/last
buckets.

Close #7275

@jpountz jpountz closed this in 436e37c Aug 18, 2014

@jpountz jpountz added the enhancement label Aug 18, 2014

@jpountz jpountz deleted the jpountz:fix/aggs_bucket_list branch Aug 18, 2014

jpountz added a commit that referenced this pull request Sep 8, 2014

Aggregations: Make the list of buckets for terms and histogram return…
…ed as a java.util.List.

The terms and histogram aggregations always have an order. So it would make the
response easier to consume to return the buckets as a list instead of a
collection in order to make it easier to do things like getting the first/last
buckets.

Close #7275

@clintongormley clintongormley changed the title Aggregations: Make the list of buckets for terms and histogram returned as a java.util.List. Make the list of buckets for terms and histogram returned as a java.util.List. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.