Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the logic to optionally sort/dedup values on the fly. #7276

Closed

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

commented Aug 14, 2014

These options are not used anymore. Instead numeric values can now contain dups
and it is the responsibility of the aggregation to deal with it (eg. terms).
And otherwise all values sources are now sorted, which is the contract of the
interfaces that they implement.

@jpountz jpountz added review labels Aug 14, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2014

LGTM

@s1monw s1monw removed the review label Aug 21, 2014

Aggregations: Remove the logic to optionally sort/dedup values on the…
… fly.

These options are not used anymore. Instead numeric values can now contain dups
and it is the responsibility of the aggregation to deal with it (eg. terms).
And otherwise all values sources are now sorted, which is the contract of the
interfaces that they implement.

@jpountz jpountz force-pushed the jpountz:fix/aggs_required_sorted_unique branch to 12bcd8f Aug 21, 2014

@jpountz jpountz closed this in ded30e9 Aug 21, 2014

jpountz added a commit that referenced this pull request Aug 21, 2014

Aggregations: Remove the logic to optionally sort/dedup values on the…
… fly.

These options are not used anymore. Instead numeric values can now contain dups
and it is the responsibility of the aggregation to deal with it (eg. terms).
And otherwise all values sources are now sorted, which is the contract of the
interfaces that they implement.

Close #7276

@jpountz jpountz deleted the jpountz:fix/aggs_required_sorted_unique branch Aug 21, 2014

@jpountz jpountz added the non-issue label Aug 21, 2014

jpountz added a commit that referenced this pull request Sep 8, 2014

Aggregations: Remove the logic to optionally sort/dedup values on the…
… fly.

These options are not used anymore. Instead numeric values can now contain dups
and it is the responsibility of the aggregation to deal with it (eg. terms).
And otherwise all values sources are now sorted, which is the contract of the
interfaces that they implement.

Close #7276

@clintongormley clintongormley changed the title Aggregations: Remove the logic to optionally sort/dedup values on the fly. Remove the logic to optionally sort/dedup values on the fly. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.