Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it possible to disable the main transport handler in TransportShardSingleOperationAction #7285

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

javanna commented Aug 14, 2014

TransportShardSingleOperationAction is currently subclassed by different transport actions. Some of them are internal only, meaning that their execution will take place only in the same node where their parent execution took place. That means that their main transport handler doesn't need to be registered, the only transport handler that's needed is the shard level one.

Added abstract method isSubAction to the parent class that tells whether the action is a main one or a subaction, used to decide whether we need to register the main transport handler.

@javanna javanna self-assigned this Aug 14, 2014

@spinscale

This comment has been minimized.

Copy link
Member

spinscale commented Aug 19, 2014

LGTM

Internal: made it possible to disable the main transport handler in T…
…ransportShardSingleOperationAction

TransportShardSingleOperationAction is currently subclassed by different transport actions. Some of them are internal only, meaning that their execution will take place only in the same node where their parent execution took place. That means that their main transport handler doesn't need to be registered, the only transport handler that's needed is the shard level one.

Added `isSubAction` method (defaults to false) to the parent class that tells whether the action is a main one or a subaction, used to decide whether we need to register the main transport handler.

Closes #7285

@javanna javanna closed this in a279f2e Aug 19, 2014

javanna added a commit that referenced this pull request Aug 19, 2014

Internal: made it possible to disable the main transport handler in T…
…ransportShardSingleOperationAction

TransportShardSingleOperationAction is currently subclassed by different transport actions. Some of them are internal only, meaning that their execution will take place only in the same node where their parent execution took place. That means that their main transport handler doesn't need to be registered, the only transport handler that's needed is the shard level one.

Added `isSubAction` method (defaults to false) to the parent class that tells whether the action is a main one or a subaction, used to decide whether we need to register the main transport handler.

Closes #7285

@javanna javanna removed the review label Aug 19, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Internal: made it possible to disable the main transport handler in T…
…ransportShardSingleOperationAction

TransportShardSingleOperationAction is currently subclassed by different transport actions. Some of them are internal only, meaning that their execution will take place only in the same node where their parent execution took place. That means that their main transport handler doesn't need to be registered, the only transport handler that's needed is the shard level one.

Added `isSubAction` method (defaults to false) to the parent class that tells whether the action is a main one or a subaction, used to decide whether we need to register the main transport handler.

Closes #7285

@clintongormley clintongormley changed the title Internal: made it possible to disable the main transport handler in TransportShardSingleOperationAction Internal: Made it possible to disable the main transport handler in TransportShardSingleOperationAction Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Made it possible to disable the main transport handler in TransportShardSingleOperationAction Made it possible to disable the main transport handler in TransportShardSingleOperationAction Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.