Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistributorDirectory shouldn't search for directory when reading existing file #7323

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@mikemccand
Copy link
Contributor

mikemccand commented Aug 18, 2014

I just changed the logic in the private getDirectory() to only call distributor.any() if there wasn't already a binding for the requested file name.

Closes #7306

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Aug 19, 2014

LGTM. Just needs some labels..

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Aug 19, 2014

Thanks @bleskes I'll commit ... on the labels, I think we are only supposed to label either the issue or the PR but not both, else it causes confusion when generating release notes? I labeled the issue (#7306) in this case ... though I should have put the review label on this one.

mikemccand added a commit that referenced this pull request Aug 19, 2014

Core: DistributorDirectory shouldn't search for directory when readin…
…g existing file

This was causing too much work e.g. when pulling node stats or when
opening a new reader, because the least_used distributor would
unnecessarily check free disk space on all path.data entires every
time we try to open a file for reading or check its length.

Closes #7306

Closes #7323

mikemccand added a commit that referenced this pull request Aug 19, 2014

Core: DistributorDirectory shouldn't search for directory when readin…
…g existing file

This was causing too much work e.g. when pulling node stats or when
opening a new reader, because the least_used distributor would
unnecessarily check free disk space on all path.data entires every
time we try to open a file for reading or check its length.

Closes #7306

Closes #7323

mikemccand added a commit that referenced this pull request Sep 8, 2014

Core: DistributorDirectory shouldn't search for directory when readin…
…g existing file

This was causing too much work e.g. when pulling node stats or when
opening a new reader, because the least_used distributor would
unnecessarily check free disk space on all path.data entires every
time we try to open a file for reading or check its length.

Closes #7306

Closes #7323

@clintongormley clintongormley changed the title Core: DistributorDirectory shouldn't search for directory when reading existing file Internal: DistributorDirectory shouldn't search for directory when reading existing file Sep 8, 2014

@clintongormley clintongormley changed the title Internal: DistributorDirectory shouldn't search for directory when reading existing file DistributorDirectory shouldn't search for directory when reading existing file Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Core: DistributorDirectory shouldn't search for directory when readin…
…g existing file

This was causing too much work e.g. when pulling node stats or when
opening a new reader, because the least_used distributor would
unnecessarily check free disk space on all path.data entires every
time we try to open a file for reading or check its length.

Closes elastic#7306

Closes elastic#7323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.