Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Only reset clients on nightly tests #7329

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kimchy
Copy link
Member

kimchy commented Aug 19, 2014

resetting the clients on each test (in after test) makes the tests running, especially in network mode, much slower, since transport client needs to be created each time when randmized to be used. Also, on OSX, the excessive connections causes bind exceptions eventually which makes running the network tests much harder on it.

[TEST] only reset clients on nightly tests
resetting the clients on each test (in after test) makes the tests running, especially in network mode, much slower, since transport client needs to be created each time when randmized to be used. Also, on OSX, the excessive connections causes bind exceptions eventually which makes running the network tests much harder on it.
closes #7329

@kimchy kimchy added review labels Aug 19, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 21, 2014

LGTM - one small comment, I think we can randomly close the client sometimes but very rarely instead of doing it all the time during nightly?

@s1monw s1monw removed the review label Aug 21, 2014

@kimchy

This comment has been minimized.

Copy link
Member Author

kimchy commented Aug 21, 2014

@s1monw ++, will add the rarely part and push

@kimchy kimchy closed this in 39a64cf Aug 21, 2014

kimchy added a commit that referenced this pull request Aug 21, 2014

[TEST] only reset clients on nightly tests
resetting the clients on each test (in after test) makes the tests running, especially in network mode, much slower, since transport client needs to be created each time when randmized to be used. Also, on OSX, the excessive connections causes bind exceptions eventually which makes running the network tests much harder on it.
closes #7329

@kimchy kimchy deleted the kimchy:reset_clients_only_on_nightly branch Aug 21, 2014

kimchy added a commit that referenced this pull request Sep 8, 2014

[TEST] only reset clients on nightly tests
resetting the clients on each test (in after test) makes the tests running, especially in network mode, much slower, since transport client needs to be created each time when randmized to be used. Also, on OSX, the excessive connections causes bind exceptions eventually which makes running the network tests much harder on it.
closes #7329

@clintongormley clintongormley changed the title [TEST] only reset clients on nightly tests Test: Only reset clients on nightly tests Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.