Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with encoding multiple levels of geo precision #7369

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@markharwood
Copy link
Contributor

markharwood commented Aug 21, 2014

  1. One issue reported by a user is due to the truncation of the geohash string. Added YAML test for this scenario
  2. Another suspect piece of code was the “toAutomaton” method that only merged the first of possibly many precisions into the result.

Closes #7368

@s1monw

View changes

rest-api-spec/test/suggest/20_context.yaml Outdated
@@ -34,6 +34,12 @@ setup:
"location":
"type" : "geo"
"precision" : "5km"
"suggest_geo_multi_level":

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 21, 2014

Contributor

can we have a java test for this instead? The REST test are not here to test functionality :)

This comment has been minimized.

Copy link
@markharwood

markharwood Aug 21, 2014

Author Contributor

I started down that route but the Java API looked to be missing the "context" part of the suggest API - I can roll a change for that into this PR if you want.

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 21, 2014

Contributor

odd isn't ContextSuggestSearchTests using the API?

This comment has been minimized.

Copy link
@markharwood

markharwood Aug 21, 2014

Author Contributor

I was looking in the wrong place, thanks

Suggest API - bugs with encoding multiple levels of geo precision.
1) One issue reported by a user is due to the truncation of the geohash string. Added Junit test for this scenario
2) Another suspect piece of code was the “toAutomaton” method that only merged the first of possibly many precisions into the result.

Closes #7368

Added Java test
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 29, 2014

LGTM

@jpountz jpountz removed the review label Aug 29, 2014

@markharwood

This comment has been minimized.

Copy link
Contributor Author

markharwood commented Aug 29, 2014

Committed in c0aef4a

@clintongormley clintongormley changed the title Suggest API - bugs with encoding multiple levels of geo precision. Suggesters: Bugs with encoding multiple levels of geo precision Sep 8, 2014

@clintongormley clintongormley changed the title Suggesters: Bugs with encoding multiple levels of geo precision Bugs with encoding multiple levels of geo precision Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.