Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to get metadata from arbitrary commit points #7376

Merged
merged 1 commit into from Aug 21, 2014

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

s1monw commented Aug 21, 2014

Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

@s1monw s1monw added bug labels Aug 21, 2014

@imotov

This comment has been minimized.

Copy link
Member

imotov commented Aug 21, 2014

LGTM

[STORE] Allow to get metadata from arbitrary commit points
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

Closes #7376

@s1monw s1monw force-pushed the s1monw:snapshot_from_commit branch to 99ef340 Aug 21, 2014

@s1monw s1monw removed the v1.2.5 label Aug 21, 2014

@s1monw s1monw merged commit 99ef340 into elastic:master Aug 21, 2014

s1monw added a commit that referenced this pull request Aug 21, 2014

[STORE] Allow to get metadata from arbitrary commit points
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

Closes #7376

s1monw added a commit that referenced this pull request Aug 21, 2014

[STORE] Allow to get metadata from arbitrary commit points
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

Closes #7376

@jpountz jpountz removed the review label Aug 26, 2014

@imotov imotov referenced this pull request Sep 2, 2014

Closed

Snapshotting NPE #7099

s1monw added a commit that referenced this pull request Sep 8, 2014

[STORE] Allow to get metadata from arbitrary commit points
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

Closes #7376

@clintongormley clintongormley changed the title [STORE] Allow to get metadata from arbitrary commit points Snapshot/Restore: Allow to get metadata from arbitrary commit points Sep 8, 2014

@imotov imotov referenced this pull request Nov 2, 2014

Closed

NPE on Snapshots #8310

@clintongormley clintongormley changed the title Snapshot/Restore: Allow to get metadata from arbitrary commit points Allow to get metadata from arbitrary commit points Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

[STORE] Allow to get metadata from arbitrary commit points
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.

Closes elastic#7376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.