Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move index templates api back to indices category and make put template and create index implement IndicesRequest #7378

Closed

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

commented Aug 21, 2014

No description provided.

Internal: move index templates api back to indices category and make …
…put template and create index implement IndicesRequest

@javanna javanna added v1.4.0 labels Aug 21, 2014

@@ -27,7 +27,7 @@
public class DeleteIndexTemplateAction extends IndicesAction<DeleteIndexTemplateRequest, DeleteIndexTemplateResponse, DeleteIndexTemplateRequestBuilder> {

public static final DeleteIndexTemplateAction INSTANCE = new DeleteIndexTemplateAction();
public static final String NAME = "cluster:admin/template/delete";

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 22, 2014

Contributor

this is a BW break right? I think we can't do this on 1.4?

This comment has been minimized.

Copy link
@javanna

javanna Aug 22, 2014

Author Member

it's ok since we have action names mapping that makes it work in a bw compatible manner. We had already changed the action names in #7105 in a bw comp manner (change not released yet, will be with 1.4).

@@ -27,7 +27,7 @@
public class GetIndexTemplatesAction extends IndicesAction<GetIndexTemplatesRequest, GetIndexTemplatesResponse, GetIndexTemplatesRequestBuilder> {

public static final GetIndexTemplatesAction INSTANCE = new GetIndexTemplatesAction();
public static final String NAME = "cluster:admin/template/get";

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 22, 2014

Contributor

same here?

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2014

I left two comments regarding BWC but other than that I think it's ok to add for consistency?

@s1monw s1monw removed the review label Aug 22, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2014

ok fair enough LGTM

@javanna javanna closed this in f4168a6 Aug 22, 2014

javanna added a commit that referenced this pull request Aug 22, 2014

Internal: move index templates api back to indices category and make …
…put template and create index implement IndicesRequest

Closes #7378

@javanna javanna self-assigned this Aug 22, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Internal: move index templates api back to indices category and make …
…put template and create index implement IndicesRequest

Closes #7378

@clintongormley clintongormley changed the title Internal: move index templates api back to indices category and make put template and create index implement IndicesRequest Move index templates api back to indices category and make put template and create index implement IndicesRequest Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.