Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to all possible fields for items #7382

Closed

Conversation

Projects
None yet
3 participants
@alexksikes
Copy link
Contributor

alexksikes commented Aug 21, 2014

Items with no specified field now defaults to all the possible fields from the
document source. Previously, we had required 'fields' to be specified either
as a top level parameter or for each item. The default behavior is now similar
to the MLT API.

More Like This Query: defaults to all possible fields for items
Items with no specified field now defaults to all the possible fields from the
document source. Previously, we had required 'fields' to be specified either
as a top level parameter or for each item. The default behavior is now similar
to the MLT API.
@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 21, 2014

What would happen eg. on a binary field or a geo shape?

@jpountz jpountz removed the review label Aug 21, 2014

@alexksikes

This comment has been minimized.

Copy link
Contributor Author

alexksikes commented Aug 22, 2014

The field must be of type string so it will be skipped.

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 22, 2014

This sounds good to me. Can you make it explicit in the documentation?

@alexksikes alexksikes added review and removed review labels Aug 22, 2014

@alexksikes alexksikes force-pushed the alexksikes:feature/mlt-default-all-fields branch to 4e0eb0f Aug 22, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 22, 2014

LGTM

alexksikes added a commit that referenced this pull request Aug 22, 2014

More Like This Query: defaults to all possible fields for items
Items with no specified field now defaults to all the possible fields from the
document source. Previously, we had required 'fields' to be specified either
as a top level parameter or for each item. The default behavior is now similar
to the MLT API.

Closes #7382

@alexksikes alexksikes deleted the alexksikes:feature/mlt-default-all-fields branch Aug 27, 2014

alexksikes added a commit that referenced this pull request Sep 8, 2014

More Like This Query: defaults to all possible fields for items
Items with no specified field now defaults to all the possible fields from the
document source. Previously, we had required 'fields' to be specified either
as a top level parameter or for each item. The default behavior is now similar
to the MLT API.

Closes #7382

@clintongormley clintongormley changed the title More Like This Query: defaults to all possible fields for items More Like This Query: Default to all possible fields for items Sep 8, 2014

@clintongormley clintongormley changed the title More Like This Query: Default to all possible fields for items Default to all possible fields for items Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.