Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made original indices optional for broadcast delete and delete by query shard requests #7406

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

javanna commented Aug 22, 2014

Shard requests like broadcast delete and delete by query, that needs to be executed on primary and all replicas, get read and written out to the transport on the same node. That means that if we add some field version checks are not enough to maintain bw comp since a newer node that holds the primary might receive the request from an older node, that didn't provide the field. Yet, when writing the request out again to a newer node that holds the replica, we do try and serialize the field although it's missing. The newer fields just needs to be set to optional in these cases, in addition to the version checks.

Re-enabled testDeleteByQuery and testDeleteRoutingRequired bw comp tests since this was the cause of their failures.

Internal: made original indices optional for broadcast delete and del…
…ete by query shard requests

Shard requests like broadcast delete and delete by query, that needs to be executed on primary and all replicas, get read and written out to the transport on the same node. That means that if we add some field version checks are not enough to maintain bw comp since a newer node that holds the primary might receive the request from an older node, that didn't provide the field. Yet, when writing the request out again to a newer node that holds the replica, we do try and serialize the field although it's missing. The newer fields just needs to be set to optional in these cases, in addition to the version checks.

Re-enabled testDeleteByQuery and testDeleteRoutingRequired bw comp tests since this was the cause of their failures.

@javanna javanna added bug labels Aug 22, 2014

@javanna javanna self-assigned this Aug 22, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 23, 2014

LGTM

javanna added a commit that referenced this pull request Aug 23, 2014

Internal: made original indices optional for broadcast delete and del…
…ete by query shard requests

Shard requests like broadcast delete and delete by query, that needs to be executed on primary and all replicas, get read and written out to the transport on the same node. That means that if we add some field version checks are not enough to maintain bw comp since a newer node that holds the primary might receive the request from an older node, that didn't provide the field. Yet, when writing the request out again to a newer node that holds the replica, we do try and serialize the field although it's missing. The newer fields just needs to be set to optional in these cases, in addition to the version checks.

Re-enabled testDeleteByQuery and testDeleteRoutingRequired bw comp tests since this was the cause of their failures.

Closes #7406

@javanna javanna closed this in 00fc54c Aug 23, 2014

@javanna javanna removed the review label Aug 23, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Internal: made original indices optional for broadcast delete and del…
…ete by query shard requests

Shard requests like broadcast delete and delete by query, that needs to be executed on primary and all replicas, get read and written out to the transport on the same node. That means that if we add some field version checks are not enough to maintain bw comp since a newer node that holds the primary might receive the request from an older node, that didn't provide the field. Yet, when writing the request out again to a newer node that holds the replica, we do try and serialize the field although it's missing. The newer fields just needs to be set to optional in these cases, in addition to the version checks.

Re-enabled testDeleteByQuery and testDeleteRoutingRequired bw comp tests since this was the cause of their failures.

Closes #7406

javanna added a commit to javanna/elasticsearch that referenced this pull request Dec 4, 2014

Internal: remove optional original indices
Original indices are optional in ShardDeleteByQueryRequest only for backwards compatibility, see elastic#7406. We can remove this in master since 2.0 will require a full cluster restart.

Closes elastic#8777

@clintongormley clintongormley changed the title Internal: made original indices optional for broadcast delete and delete by query shard requests Made original indices optional for broadcast delete and delete by query shard requests Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.