Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node's cluster name as a default for an incoming cluster state who misses it #7414

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

commented Aug 22, 2014

The ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is unexpected and can cause bugs. The bad part is that it will never correct itself until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

This commit changes the default to the node's cluster name.

Relates to #7386

[Internal] user node's cluster name as a default for an incoming clus…
…ter state who misses it

ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was  sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

 This commit changes the default to the node's cluster name.

 Relates to #7386

@bleskes bleskes added v1.4.0 and removed enhancement labels Aug 22, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2014

LGTM

@bleskes bleskes changed the title [Internal] user node's cluster name as a default for an incoming cluster state who misses it [Internal] use node's cluster name as a default for an incoming cluster state who misses it Aug 22, 2014

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2014

Looks great! Thanks!

@s1monw s1monw removed the review label Aug 22, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

commented Aug 22, 2014

LGTM

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2014

Used this pull request to resolve #7386 locally by:

  1. Applying it directly to the v1.3.2 tag.
  2. Deploying it as a master only node with the lowest id.
    2a. Had to build a tool to pick an id low enough.
  3. Stopping the current master

Then all I had to do was:

  1. Wait for the update to take (pretty much instant, but I wanted to see the disk usage freed).
  2. Remove the master only node with the new code.
  3. Start the old master.

So this works. Rather, it worked for me.

@bleskes bleskes closed this in 852a110 Aug 27, 2014

bleskes added a commit that referenced this pull request Aug 27, 2014

[Internal] user node's cluster name as a default for an incoming clus…
…ter state who misses it

ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was  sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

This commit changes the default to the node's cluster name.

Relates to #7386

Closes #7414

bleskes added a commit that referenced this pull request Aug 27, 2014

[Internal] user node's cluster name as a default for an incoming clus…
…ter state who misses it

ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

This commit changes the default to the node's cluster name.

Relates to #7386

Closes #7414

@clintongormley clintongormley changed the title [Internal] use node's cluster name as a default for an incoming cluster state who misses it Internal: Use node's cluster name as a default for an incoming cluster state who misses it Sep 8, 2014

bleskes added a commit that referenced this pull request Sep 8, 2014

[Internal] user node's cluster name as a default for an incoming clus…
…ter state who misses it

ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was  sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

This commit changes the default to the node's cluster name.

Relates to #7386

Closes #7414

@clintongormley clintongormley added >bug and removed >enhancement labels Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Use node's cluster name as a default for an incoming cluster state who misses it Use node's cluster name as a default for an incoming cluster state who misses it Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

[Internal] user node's cluster name as a default for an incoming clus…
…ter state who misses it

ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version.

This commit changes the default to the node's cluster name.

Relates to elastic#7386

Closes elastic#7414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.