Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Improve test coverage #7428

Merged
merged 2 commits into from Aug 25, 2014

Conversation

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

jpountz commented Aug 25, 2014

This pull request improves code coverage by removing dead code and adding tests to features/utility classes that were not sufficiently tested.

@jpountz jpountz changed the title [TEST] Improve test coverage Tests: Improve test coverage Aug 25, 2014

@jpountz jpountz added review labels Aug 25, 2014

@@ -224,6 +224,7 @@ protected XContentBuilder toInnerXContent(XContentBuilder builder, Params params
ArrayList<String> result = Lists.newArrayList();
while (token != Token.END_ARRAY) {
result.add(GeoUtils.parseGeoPoint(parser).geohash());
token = parser.nextToken(); //infinite loop without this line

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 25, 2014

Contributor

I think we have to break this fix out and apply it to 1.3 as well? I guess cherry-picking 4206b236112983305dc72fa4119b52f114d235c2 should do it and we can open a quick issue for it?

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 25, 2014

I left one comment otherwise this LGTM

s1monw and others added some commits Aug 22, 2014

@jpountz jpountz force-pushed the fix/coverage branch to 570c679 Aug 25, 2014

@jpountz jpountz merged commit 570c679 into master Aug 25, 2014

s1monw added a commit that referenced this pull request Aug 25, 2014

@jpountz jpountz deleted the fix/coverage branch Aug 25, 2014

@jpountz jpountz removed the review label Aug 25, 2014

dadoonet added a commit to elastic/elasticsearch-cloud-azure that referenced this pull request Sep 5, 2014

Replace Strings.startsWithIgnoreCase()
`Strings.startsWithIgnoreCase()` has been removed in elasticsearch 1.4 ans master. See elastic/elasticsearch#7428

Closes #35.

dadoonet added a commit to elastic/elasticsearch-cloud-azure that referenced this pull request Sep 5, 2014

Replace Strings.startsWithIgnoreCase()
`Strings.startsWithIgnoreCase()` has been removed in elasticsearch 1.4 ans master. See elastic/elasticsearch#7428

Closes #35.

s1monw added a commit that referenced this pull request Sep 8, 2014

@clintongormley clintongormley changed the title Tests: Improve test coverage Test: Improve test coverage Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.