Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all unsafe variants of LZF compress library functions to forbidden APIs. #7468

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@rjernst
Copy link
Member

commented Aug 26, 2014

The "optimized" encoders/decoders have been unreliable and error prone.
Also, fix LZFCompressor.compress to use LZFEncoder.safeEncode, which
creates a new safe encoder, instead of using a shared encoder (which
is not threadsafe).

Closes #8078

Add all unsafe variants of LZF compress library functions to forbidden
APIs.

The "optimized" encoders/decoders have been unreliable and error prone.
Also, fix LZFCompressor.compress to use LZFEncoder.safeEncode, which
creates a new safe encoder, instead of using a shared encoder (which
is not threadsafe).
@rmuir

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2014

looks good, thanks Ryan

@rjernst rjernst closed this in 1804f86 Aug 27, 2014

rjernst added a commit that referenced this pull request Aug 27, 2014

Internal: Add all unsafe variants of LZF compress library functions t…
…o forbidden APIs.

The "optimized" encoders/decoders have been unreliable and error prone.
Also, fix LZFCompressor.compress to use LZFEncoder.safeEncode, which
creates a new safe encoder, instead of using a shared encoder (which
is not threadsafe).

closes #7468

@rjernst rjernst added bug labels Aug 27, 2014

rjernst added a commit that referenced this pull request Sep 8, 2014

Internal: Add all unsafe variants of LZF compress library functions t…
…o forbidden APIs.

The "optimized" encoders/decoders have been unreliable and error prone.
Also, fix LZFCompressor.compress to use LZFEncoder.safeEncode, which
creates a new safe encoder, instead of using a shared encoder (which
is not threadsafe).

closes #7468

@s1monw s1monw deleted the rjernst:fix/compress-forbidden branch Oct 16, 2014

@s1monw s1monw added the v1.3.5 label Oct 16, 2014

@clintongormley clintongormley changed the title Internal: Add all unsafe variants of LZF compress library functions to forbidden APIs. Add all unsafe variants of LZF compress library functions to forbidden APIs. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.