Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java #7474

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@cfontes
Copy link
Contributor

commented Aug 27, 2014

While working on #7271 I found some methods that were not being used (I searched for the names too, to see if I could find any reflective calls) and some method parameters too.

To make it easier to merge #7271 I am submitting this as a side Pull request.

I've ran all tests and they OK!

Thanks

@jpountz jpountz self-assigned this Sep 1, 2014

@jpountz jpountz added v2.0.0 labels Sep 2, 2014

@jpountz jpountz closed this in df5d22c Sep 2, 2014

jpountz added a commit that referenced this pull request Sep 2, 2014

@jpountz jpountz added the non-issue label Sep 2, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2014

@cfontes Merged, thanks!

@cfontes cfontes deleted the cfontes:UselessParams branch Sep 3, 2014

@dadoonet

This comment has been minimized.

Copy link
Member

commented Sep 4, 2014

@jpountz Just a note. It breaks plugins as method

public static void parseMultiField(AbstractFieldMapper.Builder builder, String name, Map<String, Object> node, Mapper.TypeParser.ParserContext parserContext, String propName, Object propNode)

has been changed to:

public static void parseMultiField(AbstractFieldMapper.Builder builder, String name, Mapper.TypeParser.ParserContext parserContext, String propName, Object propNode)

Without keeping the old method and deprecate it in 1.4.0.

Not a big deal but some mapper plugin authors could hit this. (Mapper attachments is one of them :) )

dadoonet added a commit to elastic/elasticsearch-mapper-attachments that referenced this pull request Sep 4, 2014

parseMultiField() method signature change in es 1.4 and master
 As seen with elastic/elasticsearch#7474, we need to update mapper attachment plugin with this new signature.

 Closes #83.

(cherry picked from commit 20ee711)

dadoonet added a commit to elastic/elasticsearch-mapper-attachments that referenced this pull request Sep 4, 2014

parseMultiField() method signature change in es 1.4 and master
 As seen with elastic/elasticsearch#7474, we need to update mapper attachment plugin with this new signature.

 Closes #83.
@jpountz

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2014

@dadoonet Thanks for the note. At some point, I think we will need to define which (if any) internal APIs are safe to use by plugins. (Related to #7415 ?)

areek added a commit that referenced this pull request Sep 8, 2014

@clintongormley clintongormley changed the title Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java Internal: Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.