Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preference("_local") on get calls. #7477

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@GaelTadh
Copy link
Contributor

GaelTadh commented Aug 27, 2014

This commit sets preference("_local") on get calls to try and prevent
the GetRequest from being forked off.

@@ -376,11 +378,12 @@ public GetResponse queryScriptIndex(Client client, String scriptLang, String id)
}

public GetResponse queryScriptIndex(Client client, String scriptLang, String id,
long version, VersionType versionType){
long version, VersionType versionType) {
scriptLang = validateScriptLanguage(scriptLang);
return client.prepareGet(SCRIPT_INDEX, scriptLang, id)
.setVersion(version)
.setVersionType(versionType)

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 27, 2014

Contributor

I think this should have operationThreaded(false) as well?

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 27, 2014

LGTM

@GaelTadh GaelTadh force-pushed the GaelTadh:fix/timeoutscriptservice branch to 3c9889d Aug 27, 2014

Indexed Scripts : Change preference and thread option for GetRequest.
This change forces the GetRequest when a script is being loaded from an index
to use preference("_local") and threaded(false) to prevent the script service from
forking for GetRequests.

@GaelTadh GaelTadh closed this Aug 27, 2014

@clintongormley clintongormley changed the title Indexed Scripts : Use preference("_local") on get calls. Indexed Scripts/Templates : Use preference("_local") on get calls. Sep 8, 2014

@clintongormley clintongormley changed the title Indexed Scripts/Templates : Use preference("_local") on get calls. Indexed Scripts/Templates: Use preference("_local") on get calls. Sep 11, 2014

@clintongormley clintongormley changed the title Indexed Scripts/Templates: Use preference("_local") on get calls. Use preference("_local") on get calls. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.