Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network interface iteration order consistent #7494

Merged
merged 1 commit into from Aug 28, 2014

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

s1monw commented Aug 28, 2014

Today the iteration order of the interfaces might change across JVMs
this commit cleans up the NetworkUtils class and attempts to ensure
consistent iteration order across JVMs.

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Aug 28, 2014

LGTM.

@s1monw s1monw added review labels Aug 28, 2014

[CORE] Make network interface iteration order consistent
Today the iteration order of the interfaces might change across JVMs
this commit cleans up the NetworkUtils class and attempts to ensure
consistent iteration order across JVMs.

@s1monw s1monw force-pushed the s1monw:consistent_network_if branch to cc37ae1 Aug 28, 2014

@s1monw s1monw merged commit cc37ae1 into elastic:master Aug 28, 2014

@jpountz

This comment has been minimized.

FYI you could have used Collections.list(intfs) instead to avoid dealing with this crappy Enumeration interface :)

This comment has been minimized.

Copy link
Contributor Author

s1monw replied Aug 28, 2014

good call I will do another round of refactoring soong

@clintongormley clintongormley added the >bug label Sep 8, 2014

@clintongormley clintongormley changed the title [CORE] Make network interface iteration order consistent Internal: Make network interface iteration order consistent Sep 8, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Internal: Make network interface iteration order consistent Make network interface iteration order consistent Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.