New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConcurrentHashMap in SCAN search to keep track of the reader states. #7499

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@martijnvg
Member

martijnvg commented Aug 28, 2014

PR for #7478

@jpountz

This comment has been minimized.

Contributor

jpountz commented Aug 28, 2014

Should ReaderState.count and done also be made volatile to ensure visibility of the changes?

@jpountz

This comment has been minimized.

Contributor

jpountz commented Aug 28, 2014

@martijnvg just told me that they are no modified after having been added to the map, so that is fine. :-)

@jpountz

This comment has been minimized.

Contributor

jpountz commented Aug 28, 2014

LGTM

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes #7499
Closes #7478

martijnvg added a commit that referenced this pull request Aug 28, 2014

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes #7499
Closes #7478

martijnvg added a commit that referenced this pull request Aug 28, 2014

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes #7499
Closes #7478

@martijnvg martijnvg closed this in 4c690fa Aug 28, 2014

martijnvg added a commit that referenced this pull request Aug 28, 2014

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes #7499
Closes #7478

martijnvg added a commit that referenced this pull request Sep 8, 2014

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes #7499
Closes #7478

@martijnvg martijnvg deleted the martijnvg:bugs/scan_concurrent_map branch May 18, 2015

@clintongormley clintongormley changed the title from Scan: Use ConcurrentHashMap in scan search to keep track of the reader states. to Use ConcurrentHashMap in SCAN search to keep track of the reader states. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes elastic#7499
Closes elastic#7478

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Scan: Use ConcurrentHashMap instead of HashMap, because the readerSta…
…tes is accessed by multiple threads during the entire scroll session.

Closes elastic#7499
Closes elastic#7478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment