Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Suggest Client API #7507

Merged
merged 1 commit into from Sep 1, 2014

Conversation

Projects
None yet
3 participants
@areek
Copy link
Contributor

areek commented Aug 28, 2014

  • Added SuggestBuilders (analogous to QueryBuilders)
    • supporting term, phrase, completion and fuzzyCompletion suggestion builders
  • Added suggest(SuggestionBuilder) to SuggestRequest
    • previously only suggest(BytesReference) was supported
  • Use new SuggestBuilders methods in tests, instead of directly instantiating specific suggestion builder.

closes #7435

@areek areek changed the title Improved Suggest Client API: Improved Suggest Client API Aug 28, 2014

@areek areek added the review label Aug 28, 2014

@areek areek self-assigned this Aug 28, 2014

@s1monw

View changes

src/main/java/org/elasticsearch/search/suggest/SuggestBuilder.java Outdated
*/
public static TermSuggestionBuilder termSuggestion(String name) {
return new TermSuggestionBuilder(name);
public BytesReference buildAsBytes() {

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 29, 2014

Contributor

can we have javadocs for these methods? I think it's important for our public APIs that are directly userfacing

This comment has been minimized.

Copy link
@areek

areek Sep 1, 2014

Author Contributor

Added Docs


import org.elasticsearch.ElasticsearchException;

/**

This comment has been minimized.

Copy link
@s1monw

s1monw Aug 29, 2014

Contributor

Either put a doc string here or remove the comment entirely :)

This comment has been minimized.

Copy link
@areek

areek Sep 1, 2014

Author Contributor

Added exception docs

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 29, 2014

left minor comments other than that LGTM feel free to push when you fixed them

@s1monw s1monw added breaking and removed breaking labels Aug 29, 2014

Improved Suggest Client API:
- Added SuggestBuilders (analogous to QueryBuilders)
 - supporting term, phrase, completion and fuzzyCompletion suggestion builders
- Added suggest(SuggestionBuilder) to SuggestRequest
   - previously only suggest(BytesReference) was supported

closes #7435

@areek areek force-pushed the areek:feature/7435 branch to 9df10a0 Sep 1, 2014

@areek areek merged commit 9df10a0 into elastic:master Sep 1, 2014

@areek areek deleted the areek:feature/7435 branch Sep 2, 2014

@clintongormley clintongormley changed the title Improved Suggest Client API Java API: Improved Suggest Client API Sep 11, 2014

@clintongormley clintongormley changed the title Java API: Improved Suggest Client API Improved Suggest Client API Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.