Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a common base class for (Master|Nodes)FaultDetection #7512

Closed

Conversation

Projects
None yet
4 participants
@bleskes
Copy link
Member

commented Aug 29, 2014

They share a lot of settings and logic

Note: this pr is against the feature/improve_zen branch and is part of the review process of #7493

@martijnvg

This comment has been minimized.

Copy link
Member

commented Aug 29, 2014

LGTM

transportService.removeConnectionListener(connectionListener);
}

abstract void handleTransportDisconnect(DiscoveryNode node);

This comment has been minimized.

Copy link
@s1monw

s1monw Sep 1, 2014

Contributor

can we document this method?


import static org.elasticsearch.common.unit.TimeValue.timeValueSeconds;

public abstract class FaultDetection extends AbstractComponent {

This comment has been minimized.

Copy link
@s1monw

s1monw Sep 1, 2014

Contributor

a javadoc string would be awesome

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2014

left minor comments other than that LGTM

bleskes added a commit that referenced this pull request Sep 1, 2014

[Internal] Extract a common base class for (Master|Nodes)FaultDetection
They share a lot of settings and some logic.

Closes #7512
@bleskes

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2014

thx simon. Pushed this into improve_zen.

@bleskes bleskes closed this Sep 1, 2014

@bleskes bleskes deleted the bleskes:shared_fault_detection branch Sep 1, 2014

bleskes added a commit to bleskes/elasticsearch that referenced this pull request Sep 1, 2014

@bleskes bleskes added v1.4.0 and removed enhancement labels Sep 2, 2014

bleskes added a commit that referenced this pull request Sep 8, 2014

[Internal] Extract a common base class for (Master|Nodes)FaultDetection
They share a lot of settings and some logic.

Closes #7512

@clintongormley clintongormley changed the title [Internal] Extract a common base class for (Master|Nodes)FaultDetection Internal: Extract a common base class for (Master|Nodes)FaultDetection Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Extract a common base class for (Master|Nodes)FaultDetection Extract a common base class for (Master|Nodes)FaultDetection Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.