Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nested aggregator should iterate over the child doc ids in ascending order. #7514

Merged
merged 1 commit into from Aug 29, 2014

Conversation

Projects
None yet
3 participants
@martijnvg
Copy link
Member

martijnvg commented Aug 29, 2014

PR for #7505

@martijnvg martijnvg added bug labels Aug 29, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 29, 2014

LGTM

Aggregations: The nested aggregator should iterate over the child doc…
… ids in ascending order.

The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level,
but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result.

Closes #7505
Closes #7514

@martijnvg martijnvg force-pushed the martijnvg:bugs/reverse_nested_docid_order branch to 2ba4e35 Aug 29, 2014

martijnvg added a commit that referenced this pull request Aug 29, 2014

Aggregations: The nested aggregator should iterate over the child doc…
… ids in ascending order.

The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level,
but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result.

Closes #7505
Closes #7514

martijnvg added a commit that referenced this pull request Aug 29, 2014

Aggregations: The nested aggregator should iterate over the child doc…
… ids in ascending order.

The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level,
but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result.

Closes #7505
Closes #7514

@martijnvg martijnvg merged commit 2ba4e35 into elastic:master Aug 29, 2014

martijnvg added a commit that referenced this pull request Sep 8, 2014

Aggregations: The nested aggregator should iterate over the child doc…
… ids in ascending order.

The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level,
but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result.

Closes #7505
Closes #7514

@martijnvg martijnvg deleted the martijnvg:bugs/reverse_nested_docid_order branch May 18, 2015

@clintongormley clintongormley changed the title Aggregations: The nested aggregator should iterate over the child doc ids in ascending order. The nested aggregator should iterate over the child doc ids in ascending order. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Aggregations: The nested aggregator should iterate over the child doc…
… ids in ascending order.

The reverse_nested aggregator requires that the emitted doc ids are always in ascending order, which is already enforced on the scorer level,
but this also needs to be enforced on the nested aggrgetor level otherwise incorrect counts are a result.

Closes elastic#7505
Closes elastic#7514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.