Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute API response didn't filter metadata #7523

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

bleskes commented Aug 30, 2014

By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct metric parameter.

Closes #7520

PS. The name metric for filtering cluster state feels wrong, but this remains for another change (and a discussion)

[Rest] reroute API response didn't filter metadata
By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct `metric` parameter.

Closes #7520

@bleskes bleskes added the review label Aug 30, 2014

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 1, 2014

can we add constants to the metrics, so such a problem won't happen again?

@clintongormley clintongormley changed the title [Rest] reroute API response didn't filter metadata REST: Reroute API response didn't filter metadata Sep 8, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 10, 2014

@bleskes I agree with @kimchy can we add constants here? other than that LGTM

@s1monw s1monw removed the review label Sep 10, 2014

@bleskes bleskes force-pushed the bleskes:reroute_filter_metadata branch to 54f419c Sep 10, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 10, 2014

LGTM

@bleskes

This comment has been minimized.

Copy link
Member Author

bleskes commented Sep 10, 2014

@s1monw @kimchy I pushed another commit with an Enum for the metrics.

@bleskes bleskes added the review label Sep 10, 2014

@bleskes bleskes closed this in 4f8ddd9 Sep 10, 2014

bleskes added a commit that referenced this pull request Sep 10, 2014

[Rest] reroute API response didn't filter metadata
By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct `metric` parameter. We also add an enum representing the possible metrics, to avoid similar future mistakes.

Closes #7520
Closes #7523

@bleskes bleskes deleted the bleskes:reroute_filter_metadata branch Sep 10, 2014

karmi added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 15, 2014

@gmarz gmarz referenced this pull request Sep 22, 2014

Closed

Cluster reroute support #496

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title REST: Reroute API response didn't filter metadata Reroute API response didn't filter metadata Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.