Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cluster name to the "/" endpoint #7524

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

bleskes commented Aug 31, 2014

The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.

[Rest] Add the cluster name to the "/" endpoint
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.

@bleskes bleskes added v1.4.0 labels Aug 31, 2014

super(settings, client);
this.version = version;
controller.registerHandler(GET, "/", this);
controller.registerHandler(HEAD, "/", this);
this.clusterName = clusterName;

This comment has been minimized.

Copy link
@pickypg

pickypg Aug 31, 2014

Member

Unlikely to matter, but you should put this assignment above the handler registration since it hands out a reference to an incomplete object that could cause trouble.

This comment has been minimized.

Copy link
@bleskes

bleskes Sep 1, 2014

Author Member

Fair enough. Pushed another commit with this changed.

@spinscale

This comment has been minimized.

Copy link
Member

spinscale commented Sep 1, 2014

LGTM, useful tiny little piece!

@bleskes bleskes closed this in 0e6bb1f Sep 1, 2014

bleskes added a commit that referenced this pull request Sep 1, 2014

[Rest] Add the cluster name to the "/" endpoint
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.

Closes #7524

@bleskes bleskes deleted the bleskes:cluster_name_in_root branch Sep 1, 2014

bleskes added a commit that referenced this pull request Sep 8, 2014

[Rest] Add the cluster name to the "/" endpoint
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.

Closes #7524

@clintongormley clintongormley changed the title [Rest] Add the cluster name to the "/" endpoint REST: Add the cluster name to the "/" endpoint Sep 8, 2014

@clintongormley clintongormley changed the title REST: Add the cluster name to the "/" endpoint REST API: Add the cluster name to the "/" endpoint Sep 11, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title REST API: Add the cluster name to the "/" endpoint Add the cluster name to the "/" endpoint Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.