Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Randomly enable AggressiveOpts in builds #7533

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

commented Sep 2, 2014

to catch JVM bugs earlier I'd love to run builds randomly with -XX:+AggressiveOpt

@s1monw s1monw added review and removed build labels Sep 2, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2014

@mrsolo can you take a look?

@mrsolo

View changes

dev-tools/build_randomization.rb Outdated
@@ -50,7 +50,8 @@
'tests.jvm.argline' => [
{:choices => ['-server'], :method => 'get_random_one'},
{:choices => ['-XX:+UseConcMarkSweepGC', '-XX:+UseParallelGC', '-XX:+UseSerialGC', '-XX:+UseG1GC'], :method => 'get_random_one'},
{:choices => ['-XX:+UseCompressedOops', '-XX:-UseCompressedOops'], :method => 'get_random_one'}
{:choices => ['-XX:+UseCompressedOops', '-XX:-UseCompressedOops'], :method => 'get_random_one'},
{:choices => ['-XX:+AggressiveOpts'], :method => 'get_random_one_or_none'}

This comment has been minimized.

Copy link
@mrsolo

mrsolo Sep 2, 2014

Contributor

New method is not needed.

Use this instead

                      {:choices => ['-XX:+AggressiveOpts'], :method => 'get_50_percent'}
@mrsolo

View changes

dev-tools/build_randomization.rb Outdated
@@ -121,6 +122,12 @@ def get_random_one
data_array[rand(data_array.size)]
end

def get_random_one_or_none

This comment has been minimized.

Copy link
@mrsolo

mrsolo Sep 2, 2014

Contributor

Eliminate

@mrsolo

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2014

The change exposes the bug in line 293

s[k] = v.join(' ') #this should be dependent on class of v[0] and perform reduce operation instead... good enough for now. tests.javm.argline will be quoted if AgressiveOpts isn't picked

tests.jvm.argline: -server -XX:+UseSerialGC -XX:+UseCompressedOops -XX:+AggressiveOpts

tests.jvm.argline: '-server -XX:+UseG1GC -XX:-UseCompressedOops '

changing the line to

s[k] = v.compact.join(' ') will address the issue

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2014

@mrsolo thanks for the review I pushed a new commit

@mrsolo

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2014

LGTM.. pushing code change through CI

@s1monw s1monw added :Core/Infra/Build and removed review labels Sep 9, 2014

@s1monw s1monw force-pushed the s1monw:agressive_opts_build branch Sep 9, 2014

@s1monw s1monw force-pushed the s1monw:agressive_opts_build branch to 64dce61 Sep 9, 2014

@s1monw s1monw merged commit 64dce61 into elastic:master Sep 9, 2014

@s1monw s1monw deleted the s1monw:agressive_opts_build branch Sep 9, 2014

@clintongormley clintongormley changed the title [BUILD] Randomly enable AggressiveOpts in builds BUILD: Randomly enable AggressiveOpts in builds Sep 11, 2014

@clintongormley clintongormley changed the title BUILD: Randomly enable AggressiveOpts in builds Build: Randomly enable AggressiveOpts in builds Sep 11, 2014

@clintongormley clintongormley changed the title Build: Randomly enable AggressiveOpts in builds Test: Randomly enable AggressiveOpts in builds Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.