Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure headers are handed over to internal requests and streamline versioning support #7569

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

commented Sep 3, 2014

The get, put and delete indexed script apis map to get, index and delete api and internally create those corresponding requests. We need to make sure that the original headers are handed over to the new request by passing the original request in the constructor when creating the new one.

Also streamlined the support for version and version_type in the REST layer since the parameters were not consistently parsed and set to the internal java API requests. Unified the Rest actions code to make sure that the same parameters are supported in both scripts and templates actions.

Modified the REST delete template and delete script actions to make use of a client instead of using the ScriptService directly.

Removed injected client from transport actions as script service has already its own, no need to pass another one in.

@javanna javanna self-assigned this Sep 3, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2014

LGTM - good cleanup thanks luca

@s1monw s1monw removed the review label Sep 3, 2014

Indexed scripts: make sure headers are handed over to internal reques…
…ts and streamline versioning support

The get, put and delete indexed script apis map to get, index and delete api and internally create those corresponding requests. We need to make sure that the original headers are handed over to the new request by passing the original request in the constructor when creating the new one.

Also streamlined the support for version and version_type in the REST layer since the parameters were not consistently parsed and set to the internal java API requests.

Modified the REST delete template and delete script actions to make use of a client instead of using the `ScriptService` directly.

Closes #7569

@javanna javanna force-pushed the javanna:enhancement/indexed_scripts branch to ca23b73 Sep 4, 2014

javanna added a commit that referenced this pull request Sep 4, 2014

Indexed scripts: make sure headers are handed over to internal reques…
…ts and streamline versioning support

The get, put and delete indexed script apis map to get, index and delete api and internally create those corresponding requests. We need to make sure that the original headers are handed over to the new request by passing the original request in the constructor when creating the new one.

Also streamlined the support for version and version_type in the REST layer since the parameters were not consistently parsed and set to the internal java API requests.

Modified the REST delete template and delete script actions to make use of a client instead of using the `ScriptService` directly.

Closes #7569

@javanna javanna closed this in a857798 Sep 4, 2014

karmi added a commit to elastic/elasticsearch-ruby that referenced this pull request Sep 4, 2014

javanna added a commit that referenced this pull request Sep 8, 2014

Indexed scripts: make sure headers are handed over to internal reques…
…ts and streamline versioning support

The get, put and delete indexed script apis map to get, index and delete api and internally create those corresponding requests. We need to make sure that the original headers are handed over to the new request by passing the original request in the constructor when creating the new one.

Also streamlined the support for version and version_type in the REST layer since the parameters were not consistently parsed and set to the internal java API requests.

Modified the REST delete template and delete script actions to make use of a client instead of using the `ScriptService` directly.

Closes #7569

@clintongormley clintongormley changed the title Indexed scripts: make sure headers are handed over to internal requests and streamline versioning support Indexed Scripts/Templates: Make sure headers are handed over to internal requests and streamline versioning support Sep 8, 2014

@clintongormley clintongormley changed the title Indexed Scripts/Templates: Make sure headers are handed over to internal requests and streamline versioning support Make sure headers are handed over to internal requests and streamline versioning support Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.