Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LZFCompressedStreamOutput to use buffer recycler when allocating encoder #7613

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@rjernst
Copy link
Member

commented Sep 5, 2014

It should be the same instance (thread local), but better to be safe.

@rmuir

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2014

Looks good, thanks for being more defensive here.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2014

LGTM

1 similar comment
@kimchy

This comment has been minimized.

Copy link
Member

commented Sep 5, 2014

LGTM

@rjernst rjernst closed this in dd54025 Sep 5, 2014

rjernst added a commit that referenced this pull request Sep 5, 2014

@rjernst rjernst added v1.4.0 labels Sep 5, 2014

rjernst added a commit that referenced this pull request Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Change LZFCompressedStreamOutput to use buffer recycler when allocating encoder Resiliency: Change LZFCompressedStreamOutput to use buffer recycler when allocating encoder Sep 8, 2014

s1monw added a commit to s1monw/elasticsearch that referenced this pull request Oct 16, 2014

@rjernst rjernst deleted the rjernst:fix/buffer-recycler branch Jan 21, 2015

@clintongormley clintongormley changed the title Resiliency: Change LZFCompressedStreamOutput to use buffer recycler when allocating encoder Change LZFCompressedStreamOutput to use buffer recycler when allocating encoder Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.