Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Snapshots directly to the blobstore stream #7637

Merged
merged 1 commit into from Sep 8, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 8, 2014

Today we serialize the snashot metadata to a byte array and then copy
the byte array to a stream. Instead this commit moves the serialization
directly to the target stream without the intermediate representation.

@clintongormley clintongormley changed the title [STORE] Write Snapshots directly to the blobstore stream Snapshot/Restore: Write Snapshots directly to the blobstore stream Sep 8, 2014

@imotov

This comment has been minimized.

Copy link
Member

imotov commented Sep 8, 2014

LGTM

@s1monw s1monw force-pushed the s1monw:simplify_blob_store branch Sep 8, 2014

[STORE] Write Snapshots directly to the blobstore stream
Today we serialize the snashot metadata to a byte array and then copy
the byte array to a stream. Instead this commit moves the serialization
directly to the target stream without the intermediate representation.

Closes #7637

@s1monw s1monw force-pushed the s1monw:simplify_blob_store branch to 2619911 Sep 8, 2014

@s1monw s1monw merged commit 2619911 into elastic:master Sep 8, 2014

s1monw added a commit that referenced this pull request Sep 8, 2014

[STORE] Write Snapshots directly to the blobstore stream
Today we serialize the snashot metadata to a byte array and then copy
the byte array to a stream. Instead this commit moves the serialization
directly to the target stream without the intermediate representation.

Closes #7637

@s1monw s1monw deleted the s1monw:simplify_blob_store branch Sep 8, 2014

@s1monw s1monw removed the review label Sep 8, 2014

@clintongormley clintongormley changed the title Snapshot/Restore: Write Snapshots directly to the blobstore stream Write Snapshots directly to the blobstore stream Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.