Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action returns before updating stats for `NONE` operations #7639

Closed
wants to merge 1 commit into from

Conversation

@bleskes
Copy link
Member

commented Sep 8, 2014

We keep around a noop stats indicating how many update operations ended up not updating the document (typically because it didn't change). However, the TransportUpdateAction update that counter only after returning the result. This can throw off stats check which are done immediately after, potentially causing test failures.

…ions

We keep around a noop stats indicating how many update operations ended up not updating the document (typically because it didn't change). However, the TransportUpdateAction update that counter only after returning the result. This can throw off stats check which are done immediately after, potentially causing test failures.
@martijnvg

This comment has been minimized.

Copy link
Member

commented Sep 8, 2014

LGTM

1 similar comment
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2014

LGTM

@s1monw s1monw removed the review label Sep 8, 2014
@nik9000

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2014

LGTM thanks for catching my mistake!

@clintongormley clintongormley changed the title [Stats] update action returns before updating stats for `NONE` operations Stats: Update action returns before updating stats for `NONE` operations Sep 8, 2014
@bleskes bleskes closed this in 9054ce5 Sep 8, 2014
bleskes added a commit that referenced this pull request Sep 8, 2014
…ions

We keep around a noop stats indicating how many update operations ended up not updating the document (typically because it didn't change). However, the TransportUpdateAction update that counter only after returning the result. This can throw off stats check which are done immediately after, potentially causing test failures.

Closes #7639
@bleskes bleskes deleted the bleskes:noop_stats_before_return branch Sep 8, 2014
@bleskes

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2014

@clintongormley clintongormley changed the title Stats: Update action returns before updating stats for `NONE` operations Update action returns before updating stats for `NONE` operations Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.