Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Ensure BWC test run even if node.mode=local is set #7660

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 9, 2014

Today we throw an error if local transport is configured with BWC tests.
Yet, the BWC test need network to be enabled so test can just set the
required defaults.

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Sep 9, 2014

Nice! Can we do the same with ExternalTestCluster that suffers from the same problem and returns a similar error message?

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Sep 9, 2014

@javanna can you try it out - I pushed a fix for ExternalTestCluster

@s1monw s1monw added the review label Sep 9, 2014

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Sep 9, 2014

LGTM, thanks @s1monw !

[TEST] Ensure BWC test run even if node.mode=local is set
Today we throw an error if local transport is configured with BWC tests.
Yet, the BWC test need network to be enabled so test can just set the
required defaults.

Closes #7660

@s1monw s1monw force-pushed the s1monw:fix_bwc_env branch to 8ca7d5a Sep 9, 2014

@s1monw s1monw merged commit 8ca7d5a into elastic:1.x Sep 9, 2014

s1monw added a commit that referenced this pull request Sep 9, 2014

[TEST] Ensure BWC test run even if node.mode=local is set
Today we throw an error if local transport is configured with BWC tests.
Yet, the BWC test need network to be enabled so test can just set the
required defaults.

Closes #7660

@s1monw s1monw deleted the s1monw:fix_bwc_env branch Sep 9, 2014

@s1monw s1monw removed the >test label Sep 9, 2014

@clintongormley clintongormley changed the title [TEST] Ensure BWC test run even if node.mode=local is set Tests: Ensure BWC test run even if node.mode=local is set Sep 11, 2014

@clintongormley clintongormley changed the title Tests: Ensure BWC test run even if node.mode=local is set Test: Ensure BWC test run even if node.mode=local is set Sep 11, 2014

@jpountz jpountz removed the review label Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.