Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of Regex.simpleMatch() parameters #7661

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

dakrone commented Sep 9, 2014

Previously we incorrectly sent them in the wrong order, which can cause
validators not to be run for dynamic settings that have been added
matching a particular wildcard.

Also adds a small unit test that makes sure we fixed this behavior.

Fixes #7651

Fix ordering of Regex.simpleMatch() parameters
Previously we incorrectly sent them in the wrong order, which can cause
validators not to be run for dynamic settings that have been added
matching a particular wildcard.

Fixes #7651
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 9, 2014

LGTM

@dakrone dakrone merged commit fc0ee42 into elastic:master Sep 9, 2014

@clintongormley clintongormley added the >bug label Sep 11, 2014

@clintongormley clintongormley changed the title Fix ordering of Regex.simpleMatch() parameters Internal: Fix ordering of Regex.simpleMatch() parameters Sep 11, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@dakrone dakrone deleted the dakrone:7651-dynamic-settings-regex branch Nov 11, 2014

@clintongormley clintongormley changed the title Internal: Fix ordering of Regex.simpleMatch() parameters Fix ordering of Regex.simpleMatch() parameters Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.