Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused `search_query_hint` parameter #7691

Closed

Conversation

Projects
None yet
4 participants
@javanna
Copy link
Member

commented Sep 11, 2014

No description provided.

@colings86

This comment has been minimized.

Copy link
Member

commented Sep 11, 2014

Will requests using search_query_hint now fail in the parser in 1.4? if so we should probably update the breaking changes doc

@javanna

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2014

Will requests using search_query_hint now fail in the parser in 1.4? if so we should probably update the breaking changes doc

I think the parameter would just get ignored through the REST layer, no failures. Java API users would have a compilation error. Anyways I think nobody ever used this parameter since it did nothing, I would prefer not to promote it as breaking change then, but more as a bugfix :)

@alexksikes

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2014

Since the option did nothing, I agree it should rather be a bugfix. LGTM.

@javanna javanna closed this in 7e0481d Sep 11, 2014

@javanna javanna removed the >breaking label Sep 11, 2014

@clintongormley clintongormley changed the title More Like This API: remove unused search_query_hint parameter Remove unused `search_query_hint` parameter Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.