Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn unexpected exceptions when reading segments into CorruptedIndexException #7693

Merged
merged 1 commit into from Sep 11, 2014

Conversation

Projects
None yet
5 participants
@s1monw
Copy link
Contributor

commented Sep 11, 2014

Today if we run into exception like NumberFormatException or IAE
when we try to open a commit point to retrieve checksums and calculate
store metadata we just bubble them up. Yet, those are very likely index
corruptions. In such a case we should really mark the shard as
corrupted.

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2014

@bleskes @rmuir can you take a look

@bleskes

This comment has been minimized.

Copy link
Member

commented Sep 11, 2014

LGTM

[STORE] Turn unexpected exception into CorruptedIndexException
Today if we run into exception like NumberFormatException or IAE
when we try to open a commit point to retrieve checksums and calculate
store metadata we just bubble them up. Yet, those are very likely index
corruptions. In such a case we should really mark the shard as
corrupted.

@s1monw s1monw force-pushed the s1monw:catch_exc_on_corruption branch to a0e9951 Sep 11, 2014

@s1monw s1monw merged commit a0e9951 into elastic:master Sep 11, 2014

@clintongormley clintongormley changed the title [STORE] Turn unexpected exception into CorruptedIndexException Internal: Turn unexpected exceptions when reading segments into CorruptedIndexException Sep 12, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Internal: Turn unexpected exceptions when reading segments into CorruptedIndexException Turn unexpected exceptions when reading segments into CorruptedIndexException Jun 7, 2015

@lcawl lcawl added :Core/Infra/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.