Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception from Store.failIfCorrupted #7695

Merged
merged 1 commit into from Sep 11, 2014

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

commented Sep 11, 2014

If you have previously corrupted files, this method currently builds an
exception like:

    failed engine [corrupted preexisting index]
    failed to start shard

Followed by a CorruptIndexException. This commit writes the entire
stacktrace to provide additional information. It also changes the
failure message from corrupted preexisting index to preexisting corrupted index to prevent confusion.

Closes #7596

@s1monw s1monw added the review label Sep 11, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2014

@rmuir can you review please

@rmuir

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2014

looks great, thanks

[STORE] Improve exception from Store.failIfCorrupted
If you have previously corrupted files, this method currently builds an
exception like:
```
    failed engine [corrupted preexisting index]
    failed to start shard
```

Followed by a CorruptIndexException. This commit writes the entire
stacktrace to provide additional information. It also changes the
failure message from `corrupted preexisting index` to `preexisting
corrupted index` to prevent confusion.

Closes #7596

@s1monw s1monw force-pushed the s1monw:issues/7596 branch to 3ef6860 Sep 11, 2014

@s1monw s1monw removed the review label Sep 11, 2014

@s1monw s1monw merged commit 3ef6860 into elastic:master Sep 11, 2014

@clintongormley clintongormley changed the title [STORE] Improve exception from Store.failIfCorrupted Internal: Improve exception from Store.failIfCorrupted Sep 12, 2014

@clintongormley clintongormley changed the title Internal: Improve exception from Store.failIfCorrupted Improve exception from Store.failIfCorrupted Jun 7, 2015

@lcawl lcawl added :Core/Infra/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.