Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore preference to latest unicast pings describing the same node #7702

Closed

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

bleskes commented Sep 12, 2014

#5413 introduced a change where we prefer ping responses containing a master over those who don't. The same change changes the preference of acceptance if both pings have a master indication or if neither do.

#7558 added new flag to the PingResponse which changes after a node has joined the cluster for the very first time. Giving preference to older pings cause the wrong value of this flag to be used. This commit restores the preference to the original one.

Discovery: restore preference to latest unicast pings describing the …
…same node

#5413 introduced a change where we prefer ping responses containing a master over those who don't. The same change changes the preference of acceptance if both pings have a master indication or if neither do.

 #7558 added new flag to the PingResponse which changes after a node has joined the cluster for the very first time. Giving preference to older pings cause the wrong value of this flag to be used.   This commit restores the preference to the original one.
@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Sep 12, 2014

LGTM

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 12, 2014

+1 to push this as a temporary solution - can you open a followup issue?

@bleskes bleskes closed this in 1002ff2 Sep 12, 2014

bleskes added a commit that referenced this pull request Sep 12, 2014

bleskes added a commit that referenced this pull request Sep 12, 2014

@bleskes bleskes deleted the bleskes:process_unicast_pings_inorder branch Sep 12, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Discovery: restore preference to latest unicast pings describing the same node Restore preference to latest unicast pings describing the same node Jun 8, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.