Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterHealthAPI does not respect waitForEvents when local flag is set #7731

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@bleskes
Copy link
Member

bleskes commented Sep 15, 2014

It uses a cluster state update task and it gets rejected if not run on a master node. We should enable running on non-masters if the local flag is set.

Also, report any unexpected error that may happen during this cluster state update task

Internal: ClusterHealthAPI does not respect waitForEvents when local …
…flag is set

It uses a cluster state update task and it gets rejected if not run on a master node. We should enable running on non-masters if the local flag is set.

Also, report any unexpected error that may happen during this cluster state update task
@@ -74,6 +75,7 @@ protected void masterOperation(final ClusterHealthRequest request, final Cluster

if (request.waitForEvents() != null) {
final CountDownLatch latch = new CountDownLatch(1);
final AtomicReference<ElasticsearchException> failure = new AtomicReference<>();

This comment has been minimized.

Copy link
@kimchy

kimchy Sep 15, 2014

Member

can this be Throwable, and not wrapped in Elasticsearch exception?

This comment has been minimized.

Copy link
@bleskes

bleskes Sep 15, 2014

Author Member

That's how I had it and then Java complains about throwing a throwable without having it in the method signature (I wrapped it here to keep to point the stack trace here)

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 15, 2014

LGTM except for a minor comment

@bleskes bleskes closed this in db13eea Sep 15, 2014

bleskes added a commit that referenced this pull request Sep 15, 2014

Internal: ClusterHealthAPI does not respect waitForEvents when local …
…flag is set

It uses a cluster state update task and it gets rejected if not run on a master node. We should enable running on non-masters if the local flag is set.

Also, report any unexpected error that may happen during this cluster state update task

Closes #7731

bleskes added a commit that referenced this pull request Sep 15, 2014

Internal: ClusterHealthAPI does not respect waitForEvents when local …
…flag is set

It uses a cluster state update task and it gets rejected if not run on a master node. We should enable running on non-masters if the local flag is set.

Also, report any unexpected error that may happen during this cluster state update task

Closes #7731

@bleskes bleskes deleted the bleskes:health_with_local_flag branch Sep 15, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 19, 2014

LGTM

@s1monw s1monw removed the review label Sep 19, 2014

@clintongormley clintongormley changed the title Internal: ClusterHealthAPI does not respect waitForEvents when local flag is set ClusterHealthAPI does not respect waitForEvents when local flag is set Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Internal: ClusterHealthAPI does not respect waitForEvents when local …
…flag is set

It uses a cluster state update task and it gets rejected if not run on a master node. We should enable running on non-masters if the local flag is set.

Also, report any unexpected error that may happen during this cluster state update task

Closes elastic#7731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.