Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node join requests should be handled at lower priority than master election #7733

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

commented Sep 15, 2014

When a node is elected as master or receives a join request, we submit a cluster state update task. We should give the node join update task a lower priority than the elect as master to increase the chance it will not be rejected. During master election there is a big chance that these will happen concurrently.

This commit lowers the priority of node joins from IMMEDIATE to URGENT

Discovery: node join requests should be handled at lower priority tha…
…n master election

When a node is elected as master or receives a join request, we submit a cluster state update task. We should give the node join update task a lower priority than the elect as master to increase the chance it will not be rejected. During master election there is a big chance that these will happen concurrently.

This commit lowers the priority of node joins to URGENT from IMMEDIATE
@martijnvg

This comment has been minimized.

Copy link
Member

commented Sep 16, 2014

LGTM

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2014

can we add another priority maybe - maybe RIGHT_NOW!! ;)

@bleskes bleskes closed this in 12cbb32 Sep 16, 2014

bleskes added a commit that referenced this pull request Sep 16, 2014

Discovery: node join requests should be handled at lower priority tha…
…n master election

When a node is elected as master or receives a join request, we submit a cluster state update task. We should give the node join update task a lower priority than the elect as master to increase the chance it will not be rejected. During master election there is a big chance that these will happen concurrently.

This commit lowers the priority of node joins from IMMEDIATE to URGENT

Closes #7733
@bleskes

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2014

I was thinking of YESTERDAY :) thx @s1monw @martijnvg

bleskes added a commit that referenced this pull request Sep 16, 2014

Discovery: node join requests should be handled at lower priority tha…
…n master election

When a node is elected as master or receives a join request, we submit a cluster state update task. We should give the node join update task a lower priority than the elect as master to increase the chance it will not be rejected. During master election there is a big chance that these will happen concurrently.

This commit lowers the priority of node joins from IMMEDIATE to URGENT

Closes #7733

@bleskes bleskes deleted the bleskes:join_priority_urgent branch Sep 16, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Discovery: node join requests should be handled at lower priority than master election Node join requests should be handled at lower priority than master election Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Discovery: node join requests should be handled at lower priority tha…
…n master election

When a node is elected as master or receives a join request, we submit a cluster state update task. We should give the node join update task a lower priority than the elect as master to increase the chance it will not be rejected. During master election there is a big chance that these will happen concurrently.

This commit lowers the priority of node joins from IMMEDIATE to URGENT

Closes elastic#7733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.