Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicastZenPing don't rename configure host name #7747

Conversation

Projects
None yet
4 participants
@bleskes
Copy link
Member

bleskes commented Sep 16, 2014

#7719 introduced temporary node ids for nodes that can't be resolved via their address. The change is overly aggressive and creates temporary nodes also for the configure target hosts.

Discovery: UnicastZenPing don't rename configure host name
#7719 introduced temporary node ids for nodes that can't be resolved via their address. The change is overly aggressive and creates temporary nodes also for the configure target hosts.
@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Sep 16, 2014

LGTM

@bleskes bleskes closed this in 2083ca0 Sep 16, 2014

bleskes added a commit that referenced this pull request Sep 16, 2014

Discovery: UnicastZenPing don't rename configure host name
#7719 introduced temporary node ids for nodes that can't be resolved via their address. The change is overly aggressive and creates temporary nodes also for the configure target hosts.

Closes #7747

bleskes added a commit that referenced this pull request Sep 16, 2014

Discovery: UnicastZenPing don't rename configure host name
#7719 introduced temporary node ids for nodes that can't be resolved via their address. The change is overly aggressive and creates temporary nodes also for the configure target hosts.

Closes #7747

@bleskes bleskes deleted the bleskes:unicast_ping_dont_rename_previously_renamed branch Sep 16, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Discovery: UnicastZenPing don't rename configure host name UnicastZenPing don't rename configure host name Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Discovery: UnicastZenPing don't rename configure host name
elastic#7719 introduced temporary node ids for nodes that can't be resolved via their address. The change is overly aggressive and creates temporary nodes also for the configure target hosts.

Closes elastic#7747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.