Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `percent_terms_to_match` #7754

Conversation

Projects
None yet
3 participants
@alexksikes
Copy link
Contributor

alexksikes commented Sep 16, 2014

The parameter percent_terms_to_match (number of terms that must match in the
generated query) was wrongly set to the top level boolean query. This would
lead to zero or all results type of situations. This commit ensures that the
parameter is indeed applied to the query of generated terms.

MLT Query: fix percent_terms_to_match
The parameter `percent_terms_to_match` (number of terms that must match in the
generated query) was wrongly set to the top level boolean query. This would
lead to zero or all results type of situations. This commit ensures that the
parameter is indeed applied to the query of generated terms.
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 24, 2014

LGTM Yet - I think we should really support the common syntax for minimum should match and use Queries#applyMinimumShouldMatch for it. but we can do that in a different issue?

@s1monw s1monw removed the review label Sep 24, 2014

@alexksikes

This comment has been minimized.

Copy link
Contributor Author

alexksikes commented Sep 25, 2014

That would definitely be nice. However, I'd prefer to do it in another commit. This commit fixes a bug introduced when switching to using the TVs API (https://github.com/elasticsearch/elasticsearch/pull/7014/files#diff-8790389477fb6c598af492a8e673f858R153), which is a 1.4beta release.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 25, 2014

yeah lets open a different issue. so LGTM :)

alexksikes added a commit that referenced this pull request Sep 25, 2014

MLT Query: fix percent_terms_to_match
The parameter `percent_terms_to_match` (percentage of terms that must match in
the generated query) was wrongly set to the top level boolean query. This
would lead to zero or all results type of situations. This commit ensures that
the parameter is indeed applied to the query of generated terms.

Closes #7754

@alexksikes alexksikes deleted the alexksikes:feature/mlt-fix-percent_terms_to_match branch Sep 25, 2014

alexksikes added a commit that referenced this pull request Oct 2, 2014

MLT Query: fix percent_terms_to_match
The parameter `percent_terms_to_match` (percentage of terms that must match in
the generated query) was wrongly set to the top level boolean query. This
would lead to zero or all results type of situations. This commit ensures that
the parameter is indeed applied to the query of generated terms.

Closes #7754

@alexksikes alexksikes added v1.4.0 and removed v1.4.0.Beta1 labels Oct 2, 2014

@clintongormley clintongormley changed the title MLT Query: fix percent_terms_to_match Fix `percent_terms_to_match` Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

MLT Query: fix percent_terms_to_match
The parameter `percent_terms_to_match` (percentage of terms that must match in
the generated query) was wrongly set to the top level boolean query. This
would lead to zero or all results type of situations. This commit ensures that
the parameter is indeed applied to the query of generated terms.

Closes elastic#7754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.