[Transform] add method to collect deprecations from a transform configuration #77565

hendrikmuhs · 2021-09-10T15:54:41Z

add checkForDeprecations to TransformConfig and implement deprecation checks

Notes:

I refactored/moved some classes to re-use them in transform, see 1st commit: hendrikmuhs@d2938d9:
- DeprecationIssue from the deprecations plugin /CC @jakelandis
- LoggingDeprecationAccumulationHandler from ML (semantic move inside x-pack core)
the real changes start at commit 2

Approach:

I am using a similar approach to ML, checkForDeprecations parses the configuration again, but instead of the ordinary deprecation logger re-uses the collector from ML datafeeds.

Todo:

integrate into deprecation API (followup PR?)

elasticmachine · 2021-09-13T13:39:02Z

Pinging @elastic/ml-core (Team:ML)

benwtrent

I am fine with the integration into the deprecation API to be in a follow PR, especially since this PR has a larger refactor with moving things around.

Would be good to jake or another es/data-managment team member to bless this PR.

benwtrent · 2021-09-13T15:09:02Z

...plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/QueryConfig.java

+        deprecationLogger.getDeprecations().forEach(deprecationMessage -> {
+            onDeprecation.accept(
+                new DeprecationIssue(
+                    Level.CRITICAL,
+                    "Transform [" + id + "] uses deprecated query options",
+                    TransformDeprecations.QUERY_BREAKING_CHANGES_URL,
+                    deprecationMessage,
+                    false,
+                    null
+                )
+            );
+        });


ok, I like this way better than the way ML is doing it (these list of strings, etc.). Good refactoring I think++

przemekwitek

LGTM

Just 4 nits

.../plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformDeprecations.java

przemekwitek · 2021-09-14T06:29:19Z

...plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/QueryConfig.java

+        NamedXContentRegistry namedXContentRegistry,
+        DeprecationHandler deprecationHandler
+    ) throws IOException {
+        QueryBuilder query = null;


Is this local variable needed at all?

yes, for lenient parsing we only log the exception and query remains null. I could also have 2 return's, but I think 1 exit is better than 2.

...src/main/java/org/elasticsearch/xpack/core/transform/transforms/pivot/AggregationConfig.java

LoggingDeprecationAccumulationHandler into common namespace

masseyke

Hendrick asked me to review just the part about moving DeprecationIssue to x-pack core. That makes sense to me.

elasticsearchmachine · 2021-09-14T14:56:58Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 77565

…guration (elastic#77565) add checkForDeprecations to TransformConfig and implement deprecation checks

…guration (#77565) (#77752) add checkForDeprecations to TransformConfig and implement deprecation checks

fix the version check for deprecated beta transforms, this was introduced in #77565, but contained a typo (7.15 instead of 7.5)

fix the version check for deprecated beta transforms, this was introduced in elastic#77565, but contained a typo (7.15 instead of 7.5)

) * [Transform] fix version check for beta transforms (#78364) fix the version check for deprecated beta transforms, this was introduced in #77565, but contained a typo (7.15 instead of 7.5) * Update TransformConfigTests.java

hendrikmuhs added >enhancement v8.0.0 :ml/Transform Transform v7.16.0 labels Sep 10, 2021

hendrikmuhs force-pushed the transform-deprecations branch from 2030a64 to 2d280f3 Compare September 13, 2021 08:07

hendrikmuhs marked this pull request as ready for review September 13, 2021 13:38

elasticmachine added the Team:ML Meta label for the ML team label Sep 13, 2021

benwtrent approved these changes Sep 13, 2021

View reviewed changes

przemekwitek approved these changes Sep 14, 2021

View reviewed changes

Hendrik Muhs added 9 commits September 14, 2021 09:55

move DeprecationIssue into x-pack core and

c0afb21

LoggingDeprecationAccumulationHandler into common namespace

implement deprecations check for transforms

77ac20a

fix tests

a5a6149

add tests

ae17864

deprecate beta transform configs

9fd933c

fix tests

2593b48

change the warning to critical for 8.x, shall be warning for 7.x

b0876d7

fix test

ce93652

apply review comments

6b9f757

hendrikmuhs force-pushed the transform-deprecations branch from dc1e431 to 6b9f757 Compare September 14, 2021 07:56

masseyke self-requested a review September 14, 2021 14:35

masseyke approved these changes Sep 14, 2021

View reviewed changes

hendrikmuhs added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Sep 14, 2021

hendrikmuhs merged commit 8d8d546 into elastic:master Sep 14, 2021

hendrikmuhs deleted the transform-deprecations branch September 14, 2021 14:56

hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Sep 15, 2021

[Transform] add method to collect deprecations from a transform confi…

d1e1181

…guration (elastic#77565) add checkForDeprecations to TransformConfig and implement deprecation checks

hendrikmuhs mentioned this pull request Sep 15, 2021

[7.x][Transform] add method to collect deprecations from a transform configuration #77565 #77752

Merged

hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Sep 15, 2021

[Transform] add method to collect deprecations from a transform confi…

4e26eb2

…guration (elastic#77565) add checkForDeprecations to TransformConfig and implement deprecation checks

elasticsearchmachine pushed a commit that referenced this pull request Sep 15, 2021

[Transform] add method to collect deprecations from a transform confi…

a246cc9

…guration (#77565) (#77752) add checkForDeprecations to TransformConfig and implement deprecation checks

hendrikmuhs mentioned this pull request Sep 28, 2021

[Transform] fix version check for beta transforms #78364

Merged

hendrikmuhs pushed a commit that referenced this pull request Sep 28, 2021

[Transform] fix version check for beta transforms (#78364)

dfd65be

fix the version check for deprecated beta transforms, this was introduced in #77565, but contained a typo (7.15 instead of 7.5)

jakelandis added v8.0.0-beta1 and removed v8.0.0 labels Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Transform] add method to collect deprecations from a transform configuration #77565

[Transform] add method to collect deprecations from a transform configuration #77565

hendrikmuhs commented Sep 10, 2021 •

edited

elasticmachine commented Sep 13, 2021

benwtrent left a comment

benwtrent Sep 13, 2021

przemekwitek left a comment

przemekwitek Sep 14, 2021

hendrikmuhs Sep 14, 2021

masseyke left a comment

elasticsearchmachine commented Sep 14, 2021

[Transform] add method to collect deprecations from a transform configuration #77565

[Transform] add method to collect deprecations from a transform configuration #77565

Conversation

hendrikmuhs commented Sep 10, 2021 • edited

elasticmachine commented Sep 13, 2021

benwtrent left a comment

Choose a reason for hiding this comment

benwtrent Sep 13, 2021

Choose a reason for hiding this comment

przemekwitek left a comment

Choose a reason for hiding this comment

przemekwitek Sep 14, 2021

Choose a reason for hiding this comment

hendrikmuhs Sep 14, 2021

Choose a reason for hiding this comment

masseyke left a comment

Choose a reason for hiding this comment

elasticsearchmachine commented Sep 14, 2021

💔 Backport failed

hendrikmuhs commented Sep 10, 2021 •

edited